test(RHOAIENG-26485): Add new SDK e2e tests which cover Job creation for existing cluster#888
Closed
pawelpaszki wants to merge 21 commits into
Closed
test(RHOAIENG-26485): Add new SDK e2e tests which cover Job creation for existing cluster#888pawelpaszki wants to merge 21 commits into
pawelpaszki wants to merge 21 commits into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ray-jobs-feature #888 +/- ##
====================================================
- Coverage 93.65% 93.49% -0.16%
====================================================
Files 20 21 +1
Lines 1717 1767 +50
====================================================
+ Hits 1608 1652 +44
- Misses 109 115 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…for existing cluster
pawelpaszki
force-pushed
the
RHOAIENG-26485
branch
from
66d7723 to
0468436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
RHOAIENG-26485
What changes have been made
test(RHOAIENG-26485): Add new SDK e2e tests which cover Job creation for existing cluster
Verification steps
Login to ROSA cluster with RHOAI installed and run (make sure that the poetry dependencies are installed locally):
kind test should be picked up automatically by GH workflow (for GPU)
Checks